Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run CI only on push/PR to main #330

Merged
merged 4 commits into from
Jan 31, 2023
Merged

run CI only on push/PR to main #330

merged 4 commits into from
Jan 31, 2023

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Jan 30, 2023

Description
As noticed by @BSchilperoort, the CI currently runs twice when new commits are pushed to a PR. This can be limited to only run on the main branch itself or PRs to main.

@egpbos
Copy link
Member

egpbos commented Jan 31, 2023

This is great, thanks!

One small additional request: could you perhaps remove the line with types: [opened, synchronize, reopened]? It is superfluous, because those types are already the default (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request).

Ready to merge after that, afaic.

@egpbos
Copy link
Member

egpbos commented Jan 31, 2023

Oh, actually, the markdown-link-check action has the same issue... Would be super nice if that was fixed too :D

@sjvrijn
Copy link
Contributor Author

sjvrijn commented Jan 31, 2023

Should the cffconvert then also be limited to only run on push/PR to main?

@egpbos
Copy link
Member

egpbos commented Jan 31, 2023

No cffconvert is already very specific, only runs when the cff file is updated.

Lgtm!

@egpbos egpbos merged commit a1cc388 into main Jan 31, 2023
@egpbos
Copy link
Member

egpbos commented Jan 31, 2023

Thanks for both these great PRs!

@sjvrijn sjvrijn deleted the CI-only-on-main branch October 27, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants