Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code quality services (for Python) #262

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Apr 6, 2022

This PR fixes links to the Turing Way sections about online code quality services, which were all broken due to some updates there.

For Python specifically:

  • landscape.io doesn't exist anymore (at least over https)
  • add Sonarcloud, which is the default choice in the python template

- landscape.io doesn't exist anymore (at least over https)
- fix links to turing way section about online code quality services
- add Sonarcloud, which is the default choice in the python template
@egpbos
Copy link
Member Author

egpbos commented Apr 7, 2022

Note to reviewer: the link checker is failing because of dead links in master. We should make a separate PR to fix them. In this PR, landscape.io is removed, which at least removes two of the dead links.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

best_practices/language_guides/python.md Outdated Show resolved Hide resolved
best_practices/language_guides/python.md Outdated Show resolved Hide resolved
@egpbos
Copy link
Member Author

egpbos commented Apr 20, 2022

As discussed, I replaced the specific suggestions with a link to The Turing Way. I expanded a bit on our default Python template choice, including @sverhoeven's suggestion to use SonarLint locally.

@egpbos egpbos requested a review from bouweandela April 20, 2022 11:11
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouweandela bouweandela merged commit e83e292 into master Apr 22, 2022
@bouweandela bouweandela deleted the python_quality_services branch April 22, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants