Add reference to ReviewNB to Code Review section. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvanderburg
commented
Jun 29, 2021
best_practices/code_review.md
Outdated
Comment on lines
302
to
305
| You can use [ReviewNB](https://www.reviewnb.com/) for that. If you configure | ||
| your esciencecenter.nl email address as your primary email for your Github | ||
| account [here](https://github.com/settings/emails) you have access to the | ||
| academic plan with full benefits. |
There was a problem hiding this comment.
I am not sure if we should add the 2nd part about the academic plan. It is nice to know for escience center staff, but it is ofcourse not a generally applicable best practice.
There was a problem hiding this comment.
The NLeSC guide should be targeted at NLeSC staff. All generic stuff should be in The Turing Way instead. So it's okay to suggest NLeSC specific things.
c-martinez
reviewed
Jun 29, 2021
c-martinez
reviewed
Jun 29, 2021
c-martinez
reviewed
Jun 29, 2021
Co-authored-by: Carlos Martinez <c.martinez@esciencecenter.nl>
Co-authored-by: Carlos Martinez <c.martinez@esciencecenter.nl>
|
@jmaassen or @c-martinez. Sorry I lost track of this... This can be merged now! |
c-martinez
approved these changes
Dec 22, 2021
|
Thanks @svenvanderburg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reference to reviewing jupypter notebooks with ReviewNB to Code Review section.