Active crown scott 2001 #1108
Draft
Active crown scott 2001 #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add EQ to evaluate potential for crown fire Add EQ for passive crown fire igntion Set fraction of crown burnt based on this conditional Add crown fire threshold, crown fire flag, and crown fire PFT param
Co-Authored-By: Samuel Levis <slevisconsulting@gmail.com>
…active_crown_fire Resolved conflicts in fire/SFMainMod.F90
…active_crown_fire Resolved Conflicts: main/EDTypesMod.F90
Resolved conflicts: fire/SFMainMod.F90 main/EDPftvarcon.F90 main/EDTypesMod.F90 main/FatesInterfaceMod.F90 parameter_files/fates_params_default.cdl
This and next few commits resolve conflicts missed by git and caught by github
Committing only to get ./manage_externals/checkout_externals to finish
Using existing test: SMS_Lm12_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_intel.clm-FatesFireLightningPopDens
There were two copies of this parameter: a scalar and an array and the model was getting confused when trying to read them
I found references to both currentCohort%active_crown_fire_flg and currentPatch%active_crown_fire_flg and I think the latter is correct and the former incorrect
Calculate required intensity to scorch crown and canopy, then re-calculate rate of spread and fire intensity Fixes: 573 User interface changes?: No Code review:
Fix mistake in equation to solve for phi_wind as part of steps towards calculation of canopy fraction burnt.
adrifoster
added
PR status: Not Ready
adrifoster
force-pushed
the
active_crown_Scott_2001
branch
from
c95ddab
to
3090ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in changes from @jkshuman's active crown branch. @slevis-lmwg also worked on this in #857 so I'm not sure how they are different.
Will do testing, but just pushing this here so @slevis-lmwg and I can coordinate if need be.
Description:
https://github.com/jkshuman/fates/tree/active_crown_Scott_2001
getting the FATES fire module closer to having an active crown fire parameterization.
Collaborators:
@jkshuman @slevis-lmwg
Expectation of Answer Changes:
When a crown fire occurs should change answers
Checklist
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: