-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow tests for FATES luh2 data tool #1059
Draft
glemieux
wants to merge
56
commits into
NGEET:main
Choose a base branch
from
glemieux:github/python-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incorporates an update to handle a pandas deprication issue when using cftime objects. See pydata/xarray#5359
Having too many of the dependencies in the yml file was causing issue with the dependency order and limiting xesmf to an older version.
This is necessary due to a ncd_io read requirement set in dynsubgrid.
This refactor is to account for a misunderstanding in the way that the reuse of a saved regridder weights file is to be applied.
This avoids prepping the data if its already been prepped
This helps mitigate loss of storage space
bugfixes to reduce memory usage and interpret cftime reference point
Adding 'default' and 'required' option as necessary to the argparse. This helps remove some of the luh2mod code that was previously handling default options. This also adds code to handle non-historical luh2 data file input arguments. Prior to this, it was assumed that only historical data files starting at 0850-01-01 were to be used. Now this can handle luh2 scenario files. It also adds time bounds error handling.
This is adapted from the "Python Package using Anaconda". This will need additional updates.
glemieux
added
type: tools
This PR adds or updates support tools. No regression testing necessary.
github
updates to .github files typically for configuration or workflow automation
testing
Related to improvements in code testing (e.g. unit, regression, etc)
labels
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
draft
github
updates to .github files typically for configuration or workflow automation
testing
Related to improvements in code testing (e.g. unit, regression, etc)
type: tools
This PR adds or updates support tools. No regression testing necessary.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Partially addresses #1033.
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: