Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow tests for FATES luh2 data tool #1059

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Aug 2, 2023

Description:

Partially addresses #1033.

Collaborators:

Expectation of Answer Changes:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

This incorporates an update to handle a pandas deprication issue when
using cftime objects.  See pydata/xarray#5359
Having too many of the dependencies in the yml file was causing issue
with the dependency order and limiting xesmf to an older version.
This is necessary due to a ncd_io read requirement set in dynsubgrid.
glemieux and others added 23 commits May 12, 2023 22:25
This refactor is to account for a misunderstanding in the way that
the reuse of a saved regridder weights file is to be applied.
This avoids prepping the data if its already been prepped
This helps mitigate loss of storage space
bugfixes to reduce memory usage and interpret cftime reference point
Adding 'default' and 'required' option as necessary to the argparse.
This helps remove some of the luh2mod code that was previously
handling default options.

This also adds code to handle non-historical luh2 data file input
arguments.  Prior to this, it was assumed that only historical
data files starting at 0850-01-01 were to be used.  Now this
can handle luh2 scenario files.  It also adds time bounds error handling.
This is adapted from the "Python Package using Anaconda".
This will need additional updates.
@glemieux glemieux mentioned this pull request Aug 2, 2023
5 tasks
@glemieux glemieux added type: tools This PR adds or updates support tools. No regression testing necessary. github updates to .github files typically for configuration or workflow automation testing Related to improvements in code testing (e.g. unit, regression, etc) labels Aug 2, 2023
@rgknox rgknox added the draft label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft github updates to .github files typically for configuration or workflow automation testing Related to improvements in code testing (e.g. unit, regression, etc) type: tools This PR adds or updates support tools. No regression testing necessary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants