Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Strings as perfdata values #117

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Remove Strings as perfdata values #117

merged 3 commits into from
Jun 20, 2024

Conversation

RincewindsHat
Copy link
Member

No description provided.

martialblog
martialblog approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@martialblog martialblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptive approval... but those poor poor unittests need to be 🟢

@RincewindsHat
Copy link
Member Author

well, removing the testcase for the functionality I just removed should have obvious in hindsight.

@RincewindsHat RincewindsHat merged commit c9aa64b into master Jun 20, 2024
2 checks passed
@RincewindsHat RincewindsHat deleted the restricted_perfdata_types branch June 20, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martialblog martialblog martialblog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RincewindsHat @martialblog