Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3 examples #135

Merged
merged 3 commits into from
Jul 5, 2023
Merged

add 3 examples #135

merged 3 commits into from
Jul 5, 2023

Conversation

jukent
Copy link
Collaborator

@jukent jukent commented Jun 29, 2023

set_tick_direction_spine_visibility()
add_right_hand_axis()
add_major_minor_ticks()

Related to #126 (comment)

@jukent jukent marked this pull request as ready for review June 30, 2023 13:53
@jukent jukent requested a review from kafitzgerald June 30, 2023 13:53
@jukent jukent added the documentation Improvements or additions to documentation label Jun 30, 2023
@jukent jukent self-assigned this Jun 30, 2023
Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some of the plots are missing in the examples gallery notebooks. Maybe the ; after plt.show()?

And not sure if we want to clear all the notebooks first before committing those to the repo? I generally do (to keep the history cleaner and for more readable diffs), but maybe there's a reason to do otherwise. Whatever seems best.

@jukent
Copy link
Collaborator Author

jukent commented Jun 30, 2023

I'll run and upload the new notebooks for now, but if our readthedocs build isn't running the notebooks, then it fails to work as a test that each function still runs.

@jukent jukent requested a review from kafitzgerald July 5, 2023 14:26
@jukent jukent merged commit 5e40202 into NCAR:main Jul 5, 2023
8 checks passed
@jukent jukent deleted the julyexamples branch July 5, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants