Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CDK EOS ack to tox.ini #258

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Move CDK EOS ack to tox.ini #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions .github/workflows/mcp_dev_deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,24 +71,7 @@ jobs:
jq -r <<<"$VARS_JSON" 'to_entries|map("\(.key)=\(.value)\u0000")[]'
)
- name: Deploy with tox
run: |
# NOTICES
#
# 19836 AWS CDK v1 End-of-Support June 1, 2023
#
# Overview: AWS CDK v1 is currently in maintenance mode. Support for AWS
# CDK v1 will end entirely on June 1, 2023. Migrate to AWS CDK
# v2 to continue to get the latest features and fixes!
#
# Affected versions: framework: 1.*, cli: 1.*
#
# More information at: https://github.com/aws/aws-cdk/issues/19836
#
#
# If you don’t want to see a notice anymore, use "cdk acknowledge <id>".
# For example, "cdk acknowledge 19836".
cdk acknowledge 19836
tox -v -e dev -r -- deploy --require-approval never
run: tox -v -e dev -r -- deploy --require-approval never
- name: Run DB setup
run: |
setupdb=$(aws cloudformation describe-stacks \
Expand Down
16 changes: 16 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,22 @@ passenv =
commands =
nodeenv --node=18.17.1 -p
npm install -g aws-cdk@1.203.0
# NOTICES
#
# 19836 AWS CDK v1 End-of-Support June 1, 2023
#
# Overview: AWS CDK v1 is currently in maintenance mode. Support for AWS
# CDK v1 will end entirely on June 1, 2023. Migrate to AWS CDK
# v2 to continue to get the latest features and fixes!
#
# Affected versions: framework: 1.*, cli: 1.*
#
# More information at: https://github.com/aws/aws-cdk/issues/19836
#
#
# If you don’t want to see a notice anymore, use "cdk acknowledge <id>".
# For example, "cdk acknowledge 19836".
cdk acknowledge 19836
cdk --version

[testenv:dev]
Expand Down