Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the merge_request_dependencies endpoint #698

Merged

Conversation

ddieulivol
Copy link
Contributor

What does this PR do?

Adds support for the merge request dependencies endpoint: https://docs.gitlab.com/ee/api/merge_requests.html#get-merge-request-dependencies:

Gitlab.merge_request_dependencies(5, 36)

@@ -0,0 +1 @@
[{"id":1234,"blocking_merge_request":{"id":2,"target_branch":"master","source_branch":"api2","project_id":3,"title":"New feature 2","closed":false,"merged":false,"author":{"id":1,"email":"john@example.com","name":"John Smith","blocked":false,"created_at":"2012-10-19T05:56:05Z"},"assignee":{"id":2,"email":"jack@example.com","name":"Jack Smith","blocked":false,"created_at":"2012-10-19T05:56:14Z"}},"blocked_merge_request":{"id":1,"target_branch":"master","source_branch":"api","project_id":3,"title":"New feature","closed":false,"merged":false,"author":{"id":1,"email":"john@example.com","name":"John Smith","blocked":false,"created_at":"2012-10-19T05:56:05Z"},"assignee":{"id":2,"email":"jack@example.com","name":"Jack Smith","blocked":false,"created_at":"2012-10-19T05:56:14Z"}}}]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): Is there any reason to have the fixtures minimized, and not pretty-formatted? I would find them easier to maintain.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly to reduce file sizes. They're rarely maintained after being added, and I don't see a problem with prettifying and minimizing them again in any modern editor.

@NARKOZ NARKOZ merged commit f3bd928 into NARKOZ:master Aug 26, 2024
4 checks passed
@NARKOZ
Copy link
Owner

NARKOZ commented Aug 26, 2024

Thank you ❤️

@ddieulivol ddieulivol deleted the ddieulivol-merge_request_dependencies branch August 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants