IAssetType static abstract instance fix #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The new static abstract IAssetType seems to have an issue I didn't think of before. More details can be found here. dotnet/csharplang#5955
The result is that trying to create any data structure like this is impossible with the static abstract implementation of Instances.
PR
This PR is supposed to fix this issue by making IAssetType's Instance (temporarily) virtual and adding tests to ensure everyone implements a valid Instance.