Fix handleImageDtoAndGetKey function

Fixes: #60
MrBartusek · Mar 6, 2024 · 3c1d564 · 3c1d564
1 parent 673a05d
commit 3c1d564
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/apps/api/src/images/images.service.spec.ts b/apps/api/src/images/images.service.spec.ts
@@ -93,6 +93,15 @@ describe('ImagesService', () => {
 
 			expect(result).toBe(null);
 		});
+
+		it('should keep already uploaded image', async () => {
+			const document = { imageKey: 'test-key' } as DocumentWithImage;
+			const dto: ImageDto = { hasImage: true };
+
+			const result = await service.handleImageDtoAndGetKey(document, dto);
+
+			expect(result).toBe('test-key');
+		});
 	});
 
 	describe('Directly remove image', () => {

diff --git a/apps/api/src/images/images.service.ts b/apps/api/src/images/images.service.ts
@@ -42,10 +42,17 @@ export class ImagesService {
 		if (shouldDeleteImage) {
 			await this.s3Service.deleteObject(document.imageKey);
 		}
+
 		if (shouldUploadImage) {
 			return this.uploadBase64(dto.data);
 		}
 
+		const imageWasDeleted = shouldDeleteImage;
+		if (imageWasDeleted) {
+			return null;
+		} else if (documentHasImage) {
+			return document.imageKey;
+		}
 		return null;
 	}