This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3426 Fixes fullscreen exit when opening a tab #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
suggested changes
May 28, 2020
There was a problem hiding this comment.
This didn't fix it for me. STR, I used the same url in the original issue:
- go to https://www.youtube.com/watch?v=pptgMvp9uf8
- play and go full screen
- scroll down and click the link for
http://catmusic.me/
Expected:
FxR exits fullscreen mode and link is loaded in new tab
Actual
FxR stays in fullscreen mode so the navigation bar is now broken. To see, create a new window after the new tab is opened. This is all visible in the attached video to the issue.
|
@bluemarvin apparently I've missed a bunch of cases. I've pushed an update. |
bluemarvin
approved these changes
May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3426 Fixes fullscreen exit when opening a tab