Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Update keyboard placement #1203

Merged
merged 1 commit into from
May 10, 2019
Merged

Update keyboard placement #1203

merged 1 commit into from
May 10, 2019

Conversation

MortimerGoro
Copy link
Contributor

Do not merge yet, we are waiting for the final keyboard_y, keyboard_z and keyboard_world_width values from @thenadj and @jvonitter

@MortimerGoro
Copy link
Contributor Author

I got the values. This is ready for review.

daoshengmu
daoshengmu approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@daoshengmu daoshengmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MortimerGoro MortimerGoro merged commit db8e0d4 into master May 10, 2019
@bluemarvin bluemarvin deleted the final_keyboard_placement branch May 10, 2019 23:12
@cvan cvan added this to the v1.2 milestone May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daoshengmu daoshengmu daoshengmu approved these changes

@bluemarvin bluemarvin Awaiting requested review from bluemarvin

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MortimerGoro @daoshengmu @cvan