This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Zhuyin input #1161
Merged
Zhuyin input #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvan
suggested changes
May 7, 2019
app/src/common/shared/org/mozilla/vrbrowser/ui/keyboards/ChineseZhuyinKeyboard.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/org/mozilla/vrbrowser/ui/keyboards/ChineseZhuyinKeyboard.java
Show resolved
Hide resolved
|
|
||
| class DBWordHelper extends SQLiteAssetHelper { | ||
| private static final String DATABASE_NAME = "zhuyin_words.db"; | ||
| private static final int DATABASE_VERSION = 1; |
There was a problem hiding this comment.
- how do we plan to handle migrations?
- can you file a follow-up bug to document the procedure for migrating SQLite database schemas in the future?
app/src/common/shared/org/mozilla/vrbrowser/ui/keyboards/ChineseZhuyinKeyboard.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private void addExtraKeyMaps() { | ||
| addKeyCode("ㄅ", "10", "ㄅ"); |
There was a problem hiding this comment.
nit: is there any way we can avoid duplicating the characters in the layout code?
There was a problem hiding this comment.
If we want, we can do it, but that will make it be more difficult to be read.
private String findLabelFromKey(int primaryCode) {
for (Key key : mKeyboard.getKeys()) {
if (key.codes[0] == primaryCode) {
return "" + key.label;
}
}
Log.e(LOGTAG, "Error can't find label from Zhuyin keys: " + primaryCode);
return null;
}
Then addKeyCode(Character.toString((char)0x3105), "10", findLabelFromKey(0x3105));
Or
addKeyCode(“ㄅ”, "10", findLabelFromKey(int(“ㄅ”));
@cvan
I would like like to choose the second one if we want.
MortimerGoro
suggested changes
May 7, 2019
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/KeyboardWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/org/mozilla/vrbrowser/ui/keyboards/ChineseZhuyinKeyboard.java
Outdated
Show resolved
Hide resolved
daoshengmu
commented
May 7, 2019
| @@ -679,6 +679,7 @@ private void postUICommand(Runnable aRunnable) { | |||
| private void updateCandidates() { | |||
| if (mInputConnection == null || !mCurrentKeyboard.supportsAutoCompletion()) { | |||
| setAutoCompletionVisible(false); | |||
| updateSpecialKeyLabels(); | |||
| return; | |||
There was a problem hiding this comment.
@MortimerGoro . I notice we also need to update key labels for English keyboard when doing switch from SymbolKeyboard although it does not support autocompletion.
|
Landing all keyboard PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #640, we implement this for Zhuyin Keyboard.