Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Keyboard refinements #1155

Merged
merged 2 commits into from
May 6, 2019
Merged

Keyboard refinements #1155

merged 2 commits into from
May 6, 2019

Conversation

MortimerGoro
Copy link
Contributor

@MortimerGoro MortimerGoro commented May 3, 2019 •
edited
Loading

Includes some keyboard refinements from the latest spec published in #636

  • Improved margins
  • Added close button
  • Autocompletion view only visible when there are candidates
  • Keyboard top margin is the same on all languages whether there is auto completion or not

Note: This PR still doesn't change the keyboard world size, position or angle. I prefer to move that to other PR

@MortimerGoro
Copy link
Contributor Author

Better to test this together with #1151 and #1153

@MortimerGoro MortimerGoro mentioned this pull request May 3, 2019
Closed
cvan
cvan approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor

@cvan cvan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. a few nits:

  • the margins seem to close.
  • the Close × icon seems too close to the keyboard.

image

@MortimerGoro MortimerGoro merged commit 20b8c36 into master May 6, 2019
@MortimerGoro
Copy link
Contributor Author

Thanks for the review, I've increased the margins

@cvan cvan deleted the keyboard_refinements branch May 6, 2019 18:30
@cvan cvan added this to the v1.2 milestone May 6, 2019
@cvan cvan added the enhancement This issue is a new feature or request label May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@cvan cvan cvan approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
enhancement This issue is a new feature or request
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MortimerGoro @bluemarvin @cvan