Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Implement Tray theme #140

Closed
keianhzo opened this issue Jul 12, 2018 · 5 comments
Closed

Implement Tray theme #140

keianhzo opened this issue Jul 12, 2018 · 5 comments
Assignees
@keianhzo
Labels
enhancement This issue is a new feature or request P3 Backlog

Comments

@keianhzo
Copy link
Contributor

No description provided.

@keianhzo keianhzo self-assigned this Jul 12, 2018
@bluemarvin bluemarvin added the enhancement This issue is a new feature or request label Jul 12, 2018
@nancyhang nancyhang added P2 Fix in the next development iteration and removed P2 Fix in the next development iteration labels Jul 17, 2018
@nancyhang
Copy link
Contributor

nancyhang commented Jul 18, 2018 •
edited
Loading

@thenadj

@keianhzo
Copy link
Contributor Author

@thenadj There is an issue with this an is related to #67 and #66. The browser UI is Android UI components and the tray is a 3D object rendered by our custom engine. If we add the theme for select/disabled/hover for the tray it's never going to look the same as the theme for the UI. This also applies to the hovering colors and animations. We can discuss it on the next design review but just wanted to make sure that you are aware of it before doing it.

This was referenced Jul 18, 2018
Closed
Closed
@thenadj
Copy link

thenadj commented Jul 19, 2018

We have a new UI Spec for the tray, see attached.

@thenadj
Copy link

thenadj commented Jul 19, 2018

UIS-26 Mini Tray_002.pdf

@thenadj
Copy link

thenadj commented Jul 20, 2018

Here are the art assets. Not sure if it's easier to have one file with all buttons or all 3 buttons separately, so supplied both, just in case. :)

mini-tray_icons.zip
tray_buttons.zip

@keianhzo keianhzo mentioned this issue Jul 24, 2018
Merged
@cvan cvan added P3 Backlog and removed P2 Fix in the next development iteration labels Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
enhancement This issue is a new feature or request P3 Backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bluemarvin @cvan @keianhzo @thenadj @nancyhang