fixes #1643, not display fb,tw,email buttons if not configured #2008
Conversation
|
@alanmoo you may review the PR |
|
Thanks- I'll try to get to it today, though we're trying to tie up the Buyer's Guide so our petition work is a little bit of a lower priority this week. |
|
@alanmoo thanks |
|
@alanmoo can you please update me with my PR |
| </svg> | ||
| </button> | ||
| {this.props.shareLink ? |
There was a problem hiding this comment.
This code will never execute. The block on line 435 comes after a check for the same variable, so if this.props.shareLink exists, line 435 will be returned and skip the remainder of this function.
There should be multiple checks for variables to resolve this issue- one for facebook, one for twitter, and one for email. The variable you're looking for is the ones defined here. You're going to have to inspect the code to figure out how they eventually get passed to the client.
There was a problem hiding this comment.
@alanmoo I got it.. and when I inspected the code there was no prop for sharelink_twiiter, facebook and email ... can you plz help me how can I get these fields from models to jsx as I am new to react... thanks ...
There was a problem hiding this comment.
Unfortunately if I had the time to trace that, I would be solving this ticket myself. If you can't figure it out, I'd suggest checking out our good first issues
|
I'm going to close this for now, as it's been unresolved for a few months - once this issue makes its way back into the project board, we can revisit it. |
Closes #1643
[ ] Generates new fake data, if necessary
[ ] Wagtail documentation has been updated, if necessary
[ ] Includes tests, if appropriate
[ ] Migrations squashed