feat: Switch analytics config to use a zip dependency instead of local files #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l files (and enable them better)
Cervator
added
Type: Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies a slightly tweaked version of the setup we use in the engine. Trying to improve the setup a bit each time, like where the files go.
To test:
gradlew checkshould workDrawbacks: the Checkstyle config isn't injected into IntelliJ as an option for the IDE plugin 😞 We used to hack that in via
ideatask but the import-via-Gradle approach bypasses that. Could probably check part of the.ideadirectory in, but if we start doing that for multiple projects then that just seems like trading one instance of duplication (store analytics config files in every repo) for another (maintain.ideafiles in every repo)Wonder if a custom Gradle plugin could help somehow, we already do have one started ...
Only applying to
v1.xfor now, but if merged we should update elsewhere too.