Fix for ensureIndexes() logic #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VPriesnitz
pushed a commit
to VPriesnitz/morphia
that referenced
this pull request
Oct 5, 2018
* added integration tests to confirm the issue MorphiaOrg#1175 * collect indexes from subclasses only if field is an interface or abstract class * fixed errors reported by checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request should fix the issue #1175
With this fix indexes from sub-classes will not be propagated on embedded field of a definite class and hence it will not raise an exception during key calculation. This should not break anybodies implementation since creation of indexes in such scenario is blocked anyway (see related issue #1175).
The indexes from sub-classes will be still propagated if class of embedded field is an
interfaceor anabstract class, which make sense in its own way and it does not break key calculation logic. See corresponding integration test IndexHelperTest.createIndex() where 6 indexes are expected, only 4 indexes are declared in direct classes 1 index is declared in parent class and 1 index is declared in sub-class.