Projection expressions with single arguments e.g. {"$size": "$source"} #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #667 was merged, expressions could be composed such as
Projection.expression("$size", Projection.projection("field"))
Which would be translated to:
{"$size": ["$field"]}
Though
$size
only accepts a single argument, an array containing a single string is also accepted.After @e95cdc3271408000bc57cf8f94c9468de55f1c43 (Location of change) a check was added to unwrap single-argument expressions, but it assumes that the type of the argument is a
DBObject
. This fails in the above case, where the argument is a projection reference string.This PR adds a helper method for
$size
projection expressions, and a corresponding test to make sure the argument is unwrapped correctly from the arguments list.The fix for the
ClassCastException
moves the unwrapping check to the caller oftoExpressionArgs
so that the string value can be handled without a cast to DBObject causing an exception.