Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ansible facts #177

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Use ansible facts #177

merged 3 commits into from
Oct 5, 2023

Conversation

jackhodgkiss
Copy link
Contributor

Description

This PR addresses the feature that was raised in #176

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

This has been tested locally within an Ubuntu 22.04 VM deploying and removing multiple runners without issue.

@MonolithProjects MonolithProjects changed the base branch from master to develop October 3, 2023 20:42
@MonolithProjects
Copy link
Owner

Hi @jackhodgkiss could you please resolve the conflicts? Thanks

MonolithProjects
MonolithProjects approved these changes Oct 5, 2023
View reviewed changes
Copy link
Owner

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MonolithProjects MonolithProjects merged commit 870e562 into MonolithProjects:develop Oct 5, 2023
This was referenced Oct 5, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackhodgkiss @MonolithProjects @markgoddard