Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-19835] Fix GET /v1/groups skipping some groups #84

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 19, 2024

Change Summary

When Group had a lot of bound UserGroup rows, the page limit in GET /v1/groups was applied to these rows instead of distinct Groups. Fixed.

Also fix missing "Authorize" button in Swagger.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (11e7910) to head (cbd294c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
+ Coverage    92.82%   92.92%   +0.09%     
===========================================
  Files           84       84              
  Lines         2452     2444       -8     
  Branches       309      307       -2     
===========================================
- Hits          2276     2271       -5     
+ Misses         123      121       -2     
+ Partials        53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 1e8b6f5 into develop Sep 19, 2024
17 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-19835 branch September 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants