Revive coverage testing, first steps

[psteckler]

First step in reviving unit test coverage.

Update bisect_ppx in opam.export (and some other libraries).

Add script to generate coverage files. Update Makefile to invoke that script, which generates coverage files for all libraries. You can call the script with just the libraries you want coverage for, if desired.

Change -conditional flag in dune preprocessing clauses to --conditional.

This PR addresses some of the tasks listed in #6090.

[netlify]

Deploy preview for mina-staging ready!

Built with commit e7833c7

https://deploy-preview-6142--mina-staging.netlify.app

[mobileink]

By coincidence I was just researching bisect_ppx. If I understand the source (register.ml), the --conditional flag unconditionally enables the lib. Similarly the env var BISECT_ENABLE=YES unconditionally enables.

Plus it looks like the plan is to deprecate --conditional: aantron/bisect_ppx#323

[psteckler]

If I understand the source (register.ml), the --conditional flag unconditionally enables the lib. Similarly the env var BISECT_ENABLE=YES unconditionally enables.

I don't believe so. The code reads:

("--conditional",
  Arg.Set conditional,
  " Instrument only when BISECT_ENABLE is YES");

If --conditional is given, then instrumentation only happens when the env var is set.
That's the way it's worked up to now, except for the flag name.

Now that this PR is merged, I rebuilt from develop. I saw a small number (5ish) of .coverage files, in cases where the preprocessing clause did not include bisect_ppx and the flag. I'll create a fix PR for those.

Plus it looks like the plan is to deprecate --conditional: aantron/bisect_ppx#323

It will be easy enough to update the dune files and scripts when things change. The example in the dune docs that uses --instrument-with (or some such), which I believe is the plan, doesn't currently work.

[mobileink]

On Fri, Sep 25, 2020 at 8:02 PM psteckler ***@***.***> wrote: If I understand the source (register.ml <https://github.com/aantron/bisect_ppx/blob/master/src/ppx/register.ml?rgh-link-date=2020-09-26T00%3A40%3A04Z>), the --conditional flag *unconditionally* enables the lib. Similarly the env var BISECT_ENABLE=YES unconditionally enables. I don't believe so. The code reads: ("--conditional", Arg.Set conditional, " Instrument only when BISECT_ENABLE is YES"); If --conditional is given, then instrumentation only happens when the env var is set.

Oh good grief. I misread ` match !conditional with` - OCaml uses '!' as the defer operator, not the negation operator. How embarrassing/annoying! Sorry about the noise. G

…