Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fixes and refactoring #2350

Merged

Conversation

AlvinSchiller
Copy link
Collaborator

  • moved some logoutputs to be contained in logfile for better researchability
  • refactored finish routine, seperated rfid setup
  • removed "repace homedir" logic -> v2 will not be refactored to be used with a different user
  • fix special char handling in install conf file through escaping
  • harmonized install conf var writeout
  • update testdata for special chars

@AlvinSchiller AlvinSchiller added enhancement installation legacy_v2 Issues, discussions and PRs related to Version 2.x labels Apr 19, 2024
@AlvinSchiller AlvinSchiller added this to the v2.7.0 milestone Apr 19, 2024
@AlvinSchiller AlvinSchiller self-assigned this Apr 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8759564735

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.435%

Totals Coverage Status
Change from base Build 8680810264: 0.0%
Covered Lines: 451
Relevant Lines: 575

💛 - Coveralls

@AlvinSchiller
Copy link
Collaborator Author

The escaping for the wifi values also needs to be done from the WebApp.
This will be done in a different PR to be seperated from the installation changes.

@AlvinSchiller AlvinSchiller merged commit 4626e5d into MiczFlor:develop Apr 23, 2024
27 checks passed
@AlvinSchiller AlvinSchiller deleted the fix/fixes-and-refactoring branch April 23, 2024 06:28
@s-martin s-martin removed this from the v2.7.0 milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement installation legacy_v2 Issues, discussions and PRs related to Version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants