Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shutdown by rfid after 120,180,240min #2134

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

t0b3
Copy link
Contributor

@t0b3 t0b3 commented Dec 3, 2023

@MiczFlor I'd like to extend the shutdown by RFID with 120, 180, 240 minutes ... similar to the available choices through the web interface.

@coveralls
Copy link

coveralls commented Dec 3, 2023

Pull Request Test Coverage Report for Build 7078227660

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.82%

Totals Coverage Status
Change from base Build 7066625290: 0.0%
Covered Lines: 633
Relevant Lines: 824

💛 - Coveralls

@s-martin s-martin added this to the 2.5 milestone Dec 3, 2023
@s-martin
Copy link
Collaborator

s-martin commented Dec 3, 2023

Thanks for the PR.

Although we don’t plan to implement any new features for 2.x anymore, this enhancement is simple enough to add it to 2.x

@s-martin s-martin merged commit b9f5028 into MiczFlor:develop Dec 4, 2023
33 of 34 checks passed
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants