Abort installation if user is not "pi" #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrieve correct information even if called with sudo
docker env USER added. var USER is not exported by default. test installation script now uses current user and home from env. removed duplicate test script for alternative user.
activated test2 for buster
Only run once at 5, not every minute
s-martin
approved these changes
Oct 10, 2023
AlvinSchiller
added a commit
to AlvinSchiller/RPi-Jukebox-RFID
that referenced
this pull request
Dec 21, 2023
* check for user 'pi' and home '/home/pi' retrieve correct information even if called with sudo * use correct user in docker and test scripts. docker env USER added. var USER is not exported by default. test installation script now uses current user and home from env. removed duplicate test script for alternative user. * check and handle installation exitcode * harmonize workflow trigger. activated test2 for buster * fix cron schedule. Only run once at 5, not every minute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new RaspberryPi OS installations the user can freely choose a username. This is currently not supported due to many files that have user "pi" and home "/home/pi" hardcoded. See #1785
Added a validation to the installscript that checks the current user and home.
Only if the user is "pi" and home is "/home/pi" the installation will proceed, otherwise it will be aborted with an error message.
This should prevent upcoming issues during runtime until a proper solution to support a different username is implemented.
The test scripts have also been updated and harmonized and unnecessary duplicates (for a different user) have been removed.
Also the workflow files have been harmonized and buster, bullseye and altuser runs are now active on pushs, to validate changes.