Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added initial provider authorize error rule #26828

Conversation

shanejonas
Copy link
Contributor

@shanejonas shanejonas commented Aug 30, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. CHAIN_PERMISSIONS=1 BARAD_DUR=1 yarn build:test
  2. yarn test:api-specs-multichain

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shanejonas shanejonas requested a review from a team as a code owner August 30, 2024 20:51
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Aug 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/api-specs@0.10.10 None 0 254 kB metamaskbot

🚮 Removed packages: npm/@metamask/api-specs@0.10.2

View full report↗︎

Base automatically changed from sj/caip-multichain-api-specs-test to caip-multichain September 3, 2024 20:42
@shanejonas shanejonas force-pushed the sj/caip-multichain-api-specs-test-provider-authorize-errors branch from 3cd1c1b to 69b1b0a Compare September 3, 2024 20:47
Copy link

socket-security bot commented Sep 3, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@shanejonas
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested review from a team as code owners September 4, 2024 20:12
@shanejonas shanejonas force-pushed the sj/caip-multichain-api-specs-test-provider-authorize-errors branch from dcf3ef4 to 587e7d3 Compare September 9, 2024 14:12
@shanejonas
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

@metamaskbot
Copy link
Collaborator

❌ API Spec Test Failed. View the report here.

@shanejonas shanejonas merged commit 615da54 into caip-multichain Sep 11, 2024
58 of 68 checks passed
@shanejonas shanejonas deleted the sj/caip-multichain-api-specs-test-provider-authorize-errors branch September 11, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants