Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add legacy path #175

Merged
merged 3 commits into from
Jun 6, 2023
Merged

chore: Add legacy path #175

merged 3 commits into from
Jun 6, 2023

Conversation

sime
Copy link
Contributor

@sime sime commented Jun 5, 2023

Related PR MetaMask/metamask-extension#19443

Ledger users are migrating to Trezor, directly inputting their recovery phrases into the HWW. OG Ethereum users are unable to access their assets on Trezor to due the 'legacy' derivation path not available when configuring Trezor.

The Ledger integration offers the same legacy derivation path: https://github.com/MetaMask/metamask-extension/blob/f03f2d3f79ce0c54bbce033cd83cdf9c4f26b363/ui/pages/create-account/connect-hardware/index.js#LL41C1-L41C1

https://www.reddit.com/r/TREZOR/comments/13wy3xz/comment/jmlwqyw/?context=3

@sime sime requested a review from a team as a code owner June 5, 2023 18:05
@mikesposito
Copy link
Member

@sime can you add a PR description to explain this change?

@sime
Copy link
Contributor Author

sime commented Jun 6, 2023

@mikesposito Description is updated.

Related comment MetaMask/metamask-extension#19443 (comment)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 93e0b51 into MetaMask:main Jun 6, 2023
@sime
Copy link
Contributor Author

sime commented Jun 6, 2023

@Gudahtt @mikesposito What are the chances of a point release for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants