Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrezorConnect.ethereumSignTransaction
will fail if theto
address isundefined
, but thetoJSON
method of ethereumjs-tx will returnundefined
when dealing with a transaction intended to deploy a contract. With #108 we introduced a change which, for EIP-1559 transactions, we were setting theto
address (and other properties) passed toTrezorConnect.ethereumSignTransaction
according to theethereumjs-tx
toJSON
. This would result in an error. The fix is to explicitly add a normalized version of theto
property to the transaction object passed toethereumSignTransaction