Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract deployments #112

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Fix contract deployments #112

merged 3 commits into from
Dec 8, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Dec 7, 2021

TrezorConnect.ethereumSignTransaction will fail if the to address is undefined, but the toJSON method of ethereumjs-tx will return undefined when dealing with a transaction intended to deploy a contract. With #108 we introduced a change which, for EIP-1559 transactions, we were setting the to address (and other properties) passed to TrezorConnect.ethereumSignTransaction according to the ethereumjs-tx toJSON. This would result in an error. The fix is to explicitly add a normalized version of the to property to the transaction object passed to ethereumSignTransaction

@danjm danjm requested a review from a team as a code owner December 7, 2021 05:31
@danjm danjm merged commit 3259e27 into main Dec 8, 2021
@danjm danjm deleted the fix-contract-deployments branch December 8, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants