[Backport 2.28] Add test for ECP group metadata #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
wernerlewis
added
enhancement
component-crypto
wernerlewis
force-pushed
the
ecp_group_test_2.28
branch
3 times, most recently
from
83ec0bd
to
e5c06ae
Compare
Test cases added to check curve parameters and information for each curve supported. Expected parameters are taken from references: SEC 2 for NIST, RFC 5639 for Brainpool, and RFC 7748 for curve25519/curve448. Signed-off-by: Werner Lewis <werner.lewis@arm.com>
wernerlewis
force-pushed
the
ecp_group_test_2.28
branch
from
e5c06ae
to
60b50e1
Compare
Spec values are now always used for test data, and conversion to internal representation is done in the test function. Signed-off-by: Werner Lewis <werner.lewis@arm.com>
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
Signed-off-by: Werner Lewis <werner.lewis@arm.com>
AndrzejKurek
approved these changes
Sep 20, 2022
|
Please note that the original PR has been merged and this backport has not. |
gilles-peskine-arm
approved these changes
Dec 1, 2022
| return 1; | ||
| if( grp1->T_size != grp2->T_size ) | ||
| return 1; | ||
| if( grp1->T != grp2->T ) |
There was a problem hiding this comment.
This looks wrong: all the other embedded data is compared by value, but this field is compared by reference. However, it's evidently enough for what this function is used for, and it's the same in development, so that's ok for now. Filed for later
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trivial backport of #6203, with additional commit to include
mbedtls_ecp_group_cmp, taken from development branch.Test cases added to check curve parameters and information for each
curve supported. Expected parameters are taken from references: SEC 2
for NIST, RFC 5639 for Brainpool, and RFC 7748 for curve25519/curve448.
Status
READY