Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix for order value for curve448 #5825

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Backport 2.28: Fix for order value for curve448 #5825

merged 4 commits into from
Jun 27, 2022

Conversation

polhenarejos
Copy link
Contributor

Description

This is a backport of fix for #5810 into the branch mbedtls-2.28.

Status

READY

Additional comments

PR for development in #5811

Todos

  • Tests
  • Changelog updated
  • Backported

Steps to test or reproduce

See #5810 and #5811.

@polhenarejos
Fix for order value for curve448.
a93442e 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
@polhenarejos
Added fix for x448 bug to changelog.
679d1a0 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
@polhenarejos polhenarejos mentioned this pull request May 9, 2022
Merged
2 tasks
@polhenarejos polhenarejos changed the title Fix for order value for curve448 Backport 2.28: Fix for order value for curve448 May 9, 2022
@polhenarejos
Remove spaces.
c46a2f6 
Signed-off-by: Pol Henarejos <pol.henarejos@cttc.es>
@tom-cosgrove-arm tom-cosgrove-arm added bug Product Backlog priority-medium Medium priority - this can be reviewed as time permits labels May 9, 2022
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review labels Jun 17, 2022
@daverodgman
Add test-case for checking curve order
46b5cb5 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman added size-s Estimated task size: small (~2d) component-crypto Crypto primitives and low-level interfaces and removed needs-ci Needs to pass CI tests labels Jun 17, 2022
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpg mpg requested a review from AndrzejKurek June 27, 2022 07:42
@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Jun 27, 2022
AndrzejKurek
AndrzejKurek approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@AndrzejKurek AndrzejKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline missing at the end of the .data file, but I can see that that's not something we require.

@daverodgman daverodgman added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jun 27, 2022
@daverodgman daverodgman merged commit 4118092 into Mbed-TLS:mbedtls-2.28 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@polhenarejos @AndrzejKurek @tom-cosgrove-arm @mpg @daverodgman @bensze01