Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove description workarounds #2

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Remove description workarounds #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b066d
Remove description workarounds
Mause Oct 24, 2020
af64086
Remove dead code
Mause Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions duckdb_engine/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,23 @@ class Error(Exception):
@dataclass
class ConnectionWrapper:
c: duckdb.DuckDBPyConnection
description: List[str] = field(default_factory=list)
notices: List[str] = field(default_factory=list)

def cursor(self):
return self

def __getattr__(self, name):
return getattr(self.c, name)

@property
def connection(self):
return self

def close(self):
pass

@property
def rowcount(self):
return self.c.rowcount

def execute(self, statement, parameters, context):
self.c.execute(statement, parameters)
if context.result_column_struct:
self.description = context.result_column_struct[0]
else:
self.description = []

def fetchone(self):
self.description = [(None, None)]
return self.c.fetchone()

def fetchall(self):
return self.c.fetchall()

def commit(self):
self.c.commit()


def check_existance(connection, function, name, type_):
Expand Down