Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image builds and uploads for new releases #316

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Nov 10, 2023

Currently, docker image are build on new tags, but not pushed to docker due to the following buggy constraint.

if github.repository == 'MatterMiners/tardis' && github.ref == 'refs/heads/master'

However, tags are in refs/tags. The constraint was added in order avoid uploading docker images build for each pull request. This pull request achieves the same by using the following contraint instead.

if: github.repository == 'MatterMiners/tardis' && github.event_name != 'pull_request'

In addtion, I have switched building and uploading of docker images for branches other then master. Since we solely work with pull requests so far.

Thanks to @QuantumDancer for reporting that issue.

@giffels giffels self-assigned this Nov 10, 2023
@giffels giffels requested review from a team, maxfischer2781 and RHofsaess and removed request for a team November 10, 2023 08:43
@giffels giffels added the bug Something isn't working label Nov 10, 2023
@giffels giffels mentioned this pull request Nov 10, 2023
6 tasks
@giffels giffels changed the title Fix docker image builds for new releases Fix docker image builds and uploads for new releases Nov 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36ac7c1) 98.86% compared to head (cbf573e) 98.86%.

❗ Current head cbf573e differs from pull request most recent head 9433826. Consider uploading reports for the commit 9433826 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          55       55           
  Lines        2210     2210           
=======================================
  Hits         2185     2185           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@RHofsaess RHofsaess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine 👍

@giffels giffels added this pull request to the merge queue Nov 10, 2023
Merged via the queue into MatterMiners:master with commit 580115a Nov 10, 2023
16 of 17 checks passed
@giffels giffels deleted the fix/docker-build-action branch November 10, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants