Fix type of sshexecutor stdin parameter #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
changed the title
giffels
requested review from
a team,
rfvc,
mschnepf and
maxfischer2781
and removed request for
a team
giffels
commented
Nov 9, 2023
| python3 -m pip install --upgrade pip | ||
| python3 -m pip install .[contrib] | ||
| python3 -m pip install coverage codecov | ||
| python3.11 -m pip install --upgrade pip |
There was a problem hiding this comment.
Unrelated change to fix the Mac OS deployment test, which by default uses Python 3.12 now. However, some of our dependencies are not yet supporting 3.12 by now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 55 55
Lines 2210 2210
=======================================
Hits 2185 2185
Misses 25 25
☔ View full report in Codecov by Sentry. |
giffels
force-pushed
the
fix/ssh-executor-stdin
branch
from
2dc18c0
to
392a3e3
Compare
maxfischer2781
approved these changes
Nov 10, 2023
mschnepf
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During migration of our active C/T instances to a different host, we are using the first time the
HTCondorSiteAdapterin combination with theSSHExecutor. In addition, theHTCondorSiteAdapteris the only adapter that uses thestdinto add input to thecondor_submit.That triggered a bug in the
SSHExecutor, which assumed thatasyncsshrequiresstdinto be in bytes format. However, according to the documentation, it is required to be in string format.This pull request changes the type of
SSHExecutorfrom byte format to string format.