Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyauditor to 0.2.0 #311

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

QuantumDancer
Copy link
Contributor

With the release of Auditor v0.2.0, we also must update the Auditor plugin in tardis. As discussed in #306 Auditor should return an error 404 instead of 400 when a non-existing record is updated. This change is included in v0.2.0, which means that we also need to adjust the error handling here.

Furthermore, due to an update in an upstream library, we also need to change the way we create DateTime objects. However, creating records the old way with the old version of pyauditor still works when the new version is used for the Auditor server instance. For more details, see the Migration guide.

@giffels giffels requested review from a team, giffels and maxfischer2781 and removed request for a team September 26, 2023 15:13
@giffels giffels added the enhancement New feature or request label Sep 26, 2023
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, could you remove the pytz package from setup.py as well, please? It has been introduced in c2a1eb9

@QuantumDancer
Copy link
Contributor Author

Done!

LGTM! However, could you remove the pytz package from setup.py as well, please? It has been introduced in c2a1eb9

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (24cdb48) 98.90% compared to head (755c901) 98.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          55       55           
  Lines        2277     2277           
=======================================
  Hits         2252     2252           
  Misses         25       25           
Files Coverage Δ
tardis/plugins/auditor.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

● Signs point to yes

Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for your contribution.

@giffels giffels added this pull request to the merge queue Sep 28, 2023
Merged via the queue into MatterMiners:master with commit 886255e Sep 28, 2023
17 checks passed
@giffels giffels mentioned this pull request Sep 28, 2023
10 tasks
giffels added a commit to giffels/tardis that referenced this pull request Oct 5, 2023
giffels added a commit to giffels/tardis that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants