Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken yaml tags in the documentation #309

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Aug 10, 2023

Since we migrated to cobald.config.yaml_constructors, the old-style yaml tags are not working anymore. This pull request fixes broken old-stlye yaml tags in the documentation. Thanks to @harrypuuter for reporting this issue.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (48daacb) 98.90% compared to head (7fc6ae5) 98.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   98.90%   98.86%   -0.04%     
==========================================
  Files          55       55              
  Lines        2277     2210      -67     
==========================================
- Hits         2252     2185      -67     
  Misses         25       25              
Files Changed Coverage Δ
tardis/adapters/sites/cloudstack.py 100.00% <ø> (ø)
tardis/resources/drone.py 100.00% <ø> (ø)
tardis/adapters/sites/fakesite.py 100.00% <100.00%> (ø)
tardis/adapters/sites/htcondor.py 100.00% <100.00%> (ø)
tardis/adapters/sites/kubernetes.py 100.00% <100.00%> (ø)
tardis/adapters/sites/moab.py 100.00% <100.00%> (ø)
tardis/adapters/sites/openstack.py 100.00% <100.00%> (ø)
tardis/adapters/sites/slurm.py 100.00% <100.00%> (ø)
tardis/interfaces/siteadapter.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxfischer2781
Copy link
Member

Looks like there is a bit more in here than just the YAML stuff. Is this intentional?

@giffels giffels requested review from a team, mschnepf and RHofsaess and removed request for a team August 10, 2023 07:05
@giffels giffels self-assigned this Aug 10, 2023
@giffels giffels added Improvement Code Improvements Cleanup labels Aug 10, 2023
@giffels giffels mentioned this pull request Aug 10, 2023
10 tasks
@giffels
Copy link
Member Author

giffels commented Aug 10, 2023

Looks like there is a bit more in here than just the YAML stuff. Is this intentional?

Thanks for notifing. Nope, already cleaned it again.

@giffels giffels added this pull request to the merge queue Aug 10, 2023
Merged via the queue into MatterMiners:master with commit 012da0f Aug 10, 2023
19 checks passed
@giffels giffels deleted the fix/doc-yaml-tags branch August 10, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Improvement Code Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants