Add lancium site adapter #267

giffels · 2022-11-11T15:11:29Z

This pull request adds support for the Lancium Compute site utilizing the aiolancium client.

P.S.: Due to running generate_apidoc.sh some additional rst files in the documentation have been updated.

codecov-commenter · 2022-11-11T15:14:47Z

Codecov Report

Base: 98.85% // Head: 98.88% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (8fa3c3d) compared to base (7686dbb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8fa3c3d differs from pull request most recent head aa48d4b. Consider uploading reports for the commit aa48d4b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   98.85%   98.88%   +0.03%     
==========================================
  Files          55       56       +1     
  Lines        2262     2325      +63     
==========================================
+ Hits         2236     2299      +63     
  Misses         26       26

Impacted Files	Coverage Δ
tardis/adapters/sites/lancium.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

lgtm-com · 2022-11-11T15:29:08Z

This pull request introduces 2 alerts when merging fed0620 into 459f3de - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

lgtm-com · 2022-11-11T17:31:49Z

This pull request introduces 2 alerts when merging 35ef591 into 459f3de - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

lgtm-com · 2022-11-11T18:34:54Z

This pull request introduces 2 alerts when merging d950709 into 459f3de - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

tardis/adapters/sites/lancium.py

giffels · 2022-11-17T14:29:39Z

tardis/adapters/sites/lancium.py

+        logger.debug(f"{self.site_name} has status {resource_status}.")
+        resource_attributes.update(updated=datetime.now())
+        return convert_to_attribute_dict(
+            {**resource_attributes, **self.handle_response(resource_status)}


False positiv due to using partial.

tests/adapters_t/sites_t/test_lancium.py

lgtm-com · 2022-11-17T11:23:19Z

This pull request introduces 2 alerts when merging dcdfbc8 into 7686dbb - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

lgtm-com · 2022-11-17T12:47:05Z

This pull request introduces 2 alerts when merging ae9a4a1 into 7686dbb - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

lgtm-com · 2022-11-17T13:13:53Z

This pull request introduces 2 alerts when merging b0af5e5 into 7686dbb - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

lgtm-com · 2022-11-17T14:13:40Z

This pull request introduces 2 alerts when merging 8fa3c3d into 7686dbb - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

…status

lgtm-com · 2022-11-17T15:00:41Z

This pull request introduces 2 alerts when merging aa48d4b into c9db4cc - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

tardis/adapters/sites/lancium.py

RHofsaess

Looks fine 👍

maxfischer2781

Got some minor suggestions and comments. Please take a look at them, the PR is good to go otherwise.

docs/source/plugins/plugins.rst

tardis/adapters/sites/lancium.py

Co-authored-by: Max Fischer <maxfischer2781@gmail.com>

giffels · 2022-11-23T16:01:24Z

Thanks a lot for the suggestions and comments.

lgtm-com · 2022-11-23T16:15:24Z

This pull request introduces 2 alerts when merging 077c621 into c9db4cc - view on LGTM.com

new alerts:

2 for Wrong number of arguments in a call

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog.

maxfischer2781

Go for it!

RHofsaess

👍

giffels added the enhancement New feature or request label Nov 11, 2022

github-advanced-security bot found potential problems Nov 17, 2022

View reviewed changes

giffels force-pushed the add-lancium-adapter branch from 04313ab to dcdfbc8 Compare November 17, 2022 10:44

giffels force-pushed the add-lancium-adapter branch from 4898f18 to ae9a4a1 Compare November 17, 2022 12:32

giffels added 14 commits November 17, 2022 15:24

Add aiolancium depnendency

4f481e2

Add first version of lancium site adapter

20faad8

Adaed lancium adapter test template

b318e01

Exclude cobald*.yml for git

e9c89f8

Set name and resource specs in adapter code

38a1cd7

Fixes for lancium adapter

c92f7e7

Add Tardis environment to job

9c8d4ae

Add lancium deploy resource test

c2fb54c

Add tests for machine meta data, machine tye, site name and resource …

3dd0641

…status

Refactor lancium unittests

91a17b9

Test exception handling

b866201

Add documentation for lancium adapter plus additional updates

b37ce32

Add change log for lancium compute adapter

a1ec767

Satisfy Python 3.7 unittest

aa48d4b

giffels force-pushed the add-lancium-adapter branch from 8fa3c3d to aa48d4b Compare November 17, 2022 14:25

giffels marked this pull request as ready for review November 17, 2022 14:30

giffels requested review from a team and removed request for a team November 17, 2022 14:31

giffels requested review from maxfischer2781 and RHofsaess November 17, 2022 14:31

RHofsaess reviewed Nov 23, 2022

View reviewed changes

tardis/adapters/sites/lancium.py Show resolved Hide resolved

RHofsaess previously approved these changes Nov 23, 2022

View reviewed changes

maxfischer2781 requested changes Nov 23, 2022

View reviewed changes

docs/source/plugins/plugins.rst Show resolved Hide resolved

tardis/adapters/sites/lancium.py Outdated Show resolved Hide resolved

tardis/adapters/sites/lancium.py Outdated Show resolved Hide resolved

giffels dismissed RHofsaess’s stale review via f04cb6d November 23, 2022 15:54

giffels and others added 2 commits November 23, 2022 16:54

Apply suggestions from code review

f04cb6d

Co-authored-by: Max Fischer <maxfischer2781@gmail.com>

Fix flake8 issue

077c621

giffels requested review from maxfischer2781 and RHofsaess November 23, 2022 16:00

maxfischer2781 approved these changes Nov 24, 2022

View reviewed changes

RHofsaess approved these changes Nov 24, 2022

View reviewed changes

giffels merged commit 7ddc223 into MatterMiners:master Nov 24, 2022

giffels deleted the add-lancium-adapter branch November 24, 2022 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lancium site adapter #267

Add lancium site adapter #267

giffels commented Nov 11, 2022 •

edited

Loading

codecov-commenter commented Nov 11, 2022 •

edited

Loading

lgtm-com bot commented Nov 11, 2022

lgtm-com bot commented Nov 11, 2022

lgtm-com bot commented Nov 11, 2022

giffels Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

RHofsaess left a comment

maxfischer2781 left a comment

giffels commented Nov 23, 2022

lgtm-com bot commented Nov 23, 2022

maxfischer2781 left a comment

RHofsaess left a comment

Add lancium site adapter #267

Add lancium site adapter #267

Conversation

giffels commented Nov 11, 2022 • edited Loading

codecov-commenter commented Nov 11, 2022 • edited Loading

Codecov Report

lgtm-com bot commented Nov 11, 2022

lgtm-com bot commented Nov 11, 2022

lgtm-com bot commented Nov 11, 2022

giffels Nov 17, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

lgtm-com bot commented Nov 17, 2022

RHofsaess left a comment

Choose a reason for hiding this comment

maxfischer2781 left a comment

Choose a reason for hiding this comment

giffels commented Nov 23, 2022

lgtm-com bot commented Nov 23, 2022

maxfischer2781 left a comment

Choose a reason for hiding this comment

RHofsaess left a comment

Choose a reason for hiding this comment

giffels commented Nov 11, 2022 •

edited

Loading

codecov-commenter commented Nov 11, 2022 •

edited

Loading