Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CloudStackAIO version and remove event loop usage in adapter #257

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

giffels
Copy link
Member

@giffels giffels commented Jul 27, 2022

This pull request bumps the version of the CloudStackAIO client to 0.0.8 and removes the event_loop argument in the CloudStackAdapter in order to be compatible to the newest yet unreleased COBalD version.

@giffels giffels force-pushed the bump-cloudstackaio-version branch from 8642534 to d51add6 Compare July 27, 2022 14:22
@giffels giffels added the Improvement Code Improvements label Jul 27, 2022
@giffels giffels requested review from a team, maxfischer2781 and RHofsaess and removed request for a team July 27, 2022 14:24
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #257 (8642534) into master (53b99ad) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8642534 differs from pull request most recent head d51add6. Consider uploading reports for the commit d51add6 to get more accurate results

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files          54       54              
  Lines        2144     2143       -1     
==========================================
- Hits         2130     2129       -1     
  Misses         14       14              
Impacted Files Coverage Δ
tardis/adapters/sites/cloudstack.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b99ad...d51add6. Read the comment docs.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough decision...

@giffels giffels merged commit b3641c6 into MatterMiners:master Jul 28, 2022
@giffels giffels deleted the bump-cloudstackaio-version branch July 28, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants