Fix docker build on vintage Centos 7 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 54 54
Lines 2144 2144
=======================================
Hits 2130 2130
Misses 14 14 Continue to review full report at Codecov.
|
giffels
requested review from
a team,
eileen-kuehn and
mschnepf
and removed request for
a team
maxfischer2781
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one thing I had not reckoned with. Seems that Centos 7 is too old for NodeJs18.
https://github.com/MatterMiners/tardis/runs/7332117305?check_suite_focus=true#step:4:879
So, this pull request is downgrading it to NodeJS16.