Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COBalD yaml constructors, apply plugin constraint decorator and release 0.3.0 #130

Merged
merged 4 commits into from
Feb 26, 2020

Conversation

giffels
Copy link
Member

@giffels giffels commented Feb 26, 2020

This pull request

  • adds additional COBalD YAML tags to TARDIS, since the original TARDIS YAML tags are not working in unified COBalD/TARDIS configurations.
  • it applies the COBalD plugin constraint decorator to the configuration entry point, in order to load the configuration in the desired order.
  • it includes a version bump to 0.3.0.

@giffels giffels changed the title WIP: Add yaml constructors WIP: Add COBalD yaml constructors and apply plugin constraint decorator Feb 26, 2020
@giffels giffels added the bug Something isn't working label Feb 26, 2020
@giffels giffels changed the title WIP: Add COBalD yaml constructors and apply plugin constraint decorator WIP: Add COBalD yaml constructors, apply plugin constraint decorator and release 0.3.0 Feb 26, 2020
@giffels giffels changed the title WIP: Add COBalD yaml constructors, apply plugin constraint decorator and release 0.3.0 Add COBalD yaml constructors, apply plugin constraint decorator and release 0.3.0 Feb 26, 2020
@giffels giffels marked this pull request as ready for review February 26, 2020 15:52
@giffels giffels requested review from a team, rcaspart and maxfischer2781 and removed request for a team February 26, 2020 15:53
@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #130 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   99.03%   99.03%   +<.01%     
==========================================
  Files          39       39              
  Lines        1444     1446       +2     
==========================================
+ Hits         1430     1432       +2     
  Misses         14       14
Impacted Files Coverage Δ
setup.py 100% <ø> (ø) ⬆️
tardis/configuration/configuration.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2d4b5...446a9ef. Read the comment docs.

Copy link
Member

@rcaspart rcaspart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please go ahead.

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a while to go through all those changes. 👍

@giffels giffels merged commit 2a835e4 into MatterMiners:master Feb 26, 2020
@giffels giffels deleted the add-yaml-constructors branch February 26, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants