Merge pull request #290 from dirksammel/fix_auditor_components

AUDITOR plugin: fix for config without components
MatterMiners · Mar 14, 2023 · 799757e · 799757e
2 parents a55ab6a + bec7410
commit 799757e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/tardis/plugins/auditor.py b/tardis/plugins/auditor.py
@@ -41,9 +41,12 @@ def __init__(self):
                     self._resources[site.name][machine_type][resource] = getattr(
                         config, site.name
                     ).MachineMetaData[machine_type][resource]
-                    self._components[site.name][machine_type][resource] = getattr(
-                        config_auditor.components, machine_type
-                    ).get(resource, {})
+                    try:
+                        self._components[site.name][machine_type][resource] = getattr(
+                            config_auditor.components, machine_type
+                        ).get(resource, {})
+                    except AttributeError:
+                        continue
 
         self._user = getattr(config_auditor, "user", "tardis")
         self._group = getattr(config_auditor, "group", "tardis")

diff --git a/tests/plugins_t/test_auditor.py b/tests/plugins_t/test_auditor.py
@@ -163,3 +163,8 @@ def test_construct_record(self):
         self.assertEqual(len(record.components[1].scores), 1)
         self.assertEqual(record.components[1].scores[0].name, "BLUBB")
         self.assertEqual(record.components[1].scores[0].value, 1.4)
+
+    def test_missing_components(self):
+        del self.config.Plugins.Auditor.components
+        plugin = Auditor()
+        self.assertEqual(plugin._components, {"testsite": {"test_machine_type": {}}})