Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermediate release 0.12.2 #94

Merged
merged 8 commits into from
Sep 16, 2021
Merged

Intermediate release 0.12.2 #94

merged 8 commits into from
Sep 16, 2021

Conversation

maxfischer2781
Copy link
Member

@maxfischer2781 maxfischer2781 commented Sep 15, 2021 •
edited
Loading

This release publishes accumulated changes and fixes. Notable changes include:

Auxiliary changes:

  • Current lint standards
  • Change log regenerated
  • Version bump

If merged, a new release will be published to PyPI.

@maxfischer2781 maxfischer2781 marked this pull request as ready for review September 15, 2021 19:44
@maxfischer2781 maxfischer2781 mentioned this pull request Sep 16, 2021
Open
@maxfischer2781 maxfischer2781 requested review from a team, eileen-kuehn, mschnepf and giffels and removed request for a team September 16, 2021 08:16
@maxfischer2781
Copy link
Member Author

Heads up that there are some spurious test failures – see #95 for tracking. They don't seem related to the code changes, nor should they be relevant for production.

I would prefer to make this release before looking into the failures so that current bugfixes are available promptly. Fixing the failures may involve larger changes that are more suitable for a "major" release instead.

giffels
giffels requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work. It looks fine to me. However, could you comment on my inline comments, please? This not a show stopper, however I would like have this discussed before the approval.

src/cobald/daemon/config/mapping.py Show resolved Hide resolved
src/cobald/daemon/core/logger.py Show resolved Hide resolved
giffels
giffels approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. Thanks for the contribution.

src/cobald/daemon/core/logger.py Show resolved Hide resolved
eileen-kuehn
eileen-kuehn approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my point of view. Go for it 🥇 and push for pypi.

@maxfischer2781 maxfischer2781 merged commit b16f88d into master Sep 16, 2021
@maxfischer2781 maxfischer2781 deleted the releases/v0.12.2 branch January 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giffels giffels giffels approved these changes

@eileen-kuehn eileen-kuehn eileen-kuehn approved these changes

@mschnepf mschnepf Awaiting requested review from mschnepf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxfischer2781 @giffels @eileen-kuehn