-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI cleanup and general maintenance #121
Conversation
Codecov ReportBase: 92.73% // Head: 92.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 34 34
Lines 1143 1143
Branches 166 166
=======================================
Hits 1060 1060
Misses 60 60
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -5,19 +5,15 @@ | |||
|
|||
|
|||
class TestRelativeSupplyController(object): | |||
def test_low_scale(self): | |||
def test_parameter_verification(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I combined these three test cases into one as before reading all of them it wasn't clear to me what each one tested. The new name hopefully makes this clearer.
@@ -1,6 +1,6 @@ | |||
[flake8] | |||
statistics = True | |||
max-line-length = 80 | |||
ignore = E501, B008, B011, W503 | |||
ignore = E501, B008, B011, W503, B905 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -34,7 +34,8 @@ def runners(self): | |||
DeprecationWarning( | |||
"Accessing 'MetaRunner.runners' directly is deprecated. " | |||
"Use register_payload or run_payload with the correct flavour instead." | |||
) | |||
), | |||
stacklevel=2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed according to flake8-bugbear:
B028: No explicit stacklevel keyword argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you take a look and my inline comment. Otherwise it LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution.
This PR makes adjustment for general maintenance and to keep CI going. Major changes include:
a: SomeType = ...
instead ofa = ... # type: SomeType
)0 10 * * 3
is "10:00 every Wednesday"There are no outwards facing functional changes.
I've added comments on this PR where fixes aren't obvious, mostly relating to specific flake8 checks.