asyncio runner discards KI of payloads #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 92.55% 92.73% +0.18%
==========================================
Files 34 34
Lines 1141 1143 +2
Branches 167 166 -1
==========================================
+ Hits 1056 1060 +4
+ Misses 61 60 -1
+ Partials 24 23 -1
Continue to review full report at Codecov.
|
maxfischer2781
requested review from
a team,
giffels and
eileen-kuehn
and removed request for
a team
giffels
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts cleanup of tasks by the
asynciorunner. This allows payloads/services to die/abort with an explicitraise KeyboardInterruptwithout triggering aTask exception was never retrievedwarning.An unhandled
KeyboardInterruptgracefully stops the event loop, similar to how it stops regular synchronous programs. However,asyncioconsiders a task killed this way still as exceptionally terminated and will issue a warning if the exception has not been retrieved. The changes of this PR ensure that theasynciorunner takes care of retrieving all such exceptions from it own tasks.