Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust version to 1.74.1 #25331

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Bump Rust version to 1.74.1 #25331

merged 1 commit into from
Feb 19, 2024

Conversation

def-
Copy link
Contributor

@def- def- commented Feb 16, 2024

Fixes: #24818
Release notes: https://releases.rs/docs/1.74.1/
The fix we need for aarch64 compilation is rust-lang/rust#118464

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def- def- changed the title Bump Rust version to 1.76.0 Bump Rust version to 1.74.1 Feb 16, 2024
@def- def- marked this pull request as ready for review February 16, 2024 15:35
@def- def- requested a review from a team as a code owner February 16, 2024 15:35
@def- def- requested a review from ParkMyCar February 16, 2024 15:35
@def- def- enabled auto-merge February 16, 2024 15:36
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also bump the NIGHTLY_RUST_DATE

Thanks!

@nrainer-materialize
Copy link
Contributor

Disabling auto-merge because of @ParkMyCar's comment.

@def- def- force-pushed the pr-rust-1.76.0 branch 6 times, most recently from 2e6a9ed to 92e2200 Compare February 19, 2024 15:36
@benesch
Copy link
Member

benesch commented Feb 19, 2024

You should also bump the NIGHTLY_RUST_DATE

Unless I'm missing it this could still use a bump. I think it's fine to defer that bump until the 1.76 bump though.

@def-
Copy link
Contributor Author

def- commented Feb 19, 2024

Indeed. I tried bumping the nightly version but that failed because of various reasons, so I tried a few versions inbetween, but they all fail for some reasons. Fixing the newest version will require a new version of nextest to be released, so I didn't want to block this since rustc is still panicking and making CI slightly annoying.

@benesch
Copy link
Member

benesch commented Feb 19, 2024

Yup makes sense! Removing the ARM segfaults seems more important.

@def- def- merged commit a7e5369 into MaterializeInc:main Feb 19, 2024
72 checks passed
@def- def- deleted the pr-rust-1.76.0 branch February 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc on aarch64 segfaults sporadically
4 participants