Add AP to control SmartHint resting position #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
added
enhancement
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3460
This PR adds an opt-in feature for the
SmartHintto control theHorizontalAlignmentof the hint in the resting position as requested in the issue above.This will conflict with my PR for refactoring the
SmartHintpositioning, but it shouldn't be too much of an issue to merge/rebase it and let the new scheme respect this new AP.Animations below slowed down for demonstration purposes.
I wanted to add a UI test for this, but my attempts turned out too fragile IMO, so I left it out. Basically the horizontal positioning of the hint is controlled using the
Margin(left) property of theContentControlcontaining the hint. This PR does not change that fact, it simply takes the new AP into account in the calculation of the left margin.Rest = Left, Float = Inherit
Rest = Center, Float = Inherit
Rest = Right, Float = Inherit