Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 6.3.2 - Error: Cannot find module '@babel/helper-module-imports' #53

Closed
le0nik opened this issue Apr 6, 2018 · 6 comments
Closed

Comments

@le0nik
Copy link

le0nik commented Apr 6, 2018

@babel/helper-module-imports is being used in plugin.js but is not present in package.json's dependencies.

Error: Cannot find module '@babel/helper-module-imports'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at module.exports (*****/fast-async/plugin.js:10:25)
@SeeThruHead
Copy link

also seeing this
fast-async/plugin.js still requires that file.

@rjharmon
Copy link

rjharmon commented Apr 7, 2018

this can also affect users of neutrino's 'web' and 'react' presets.

@jzaefferer
Copy link

Looks like the dependency was removed here: ad8383f - its unclear though why it was removed without any other changes.

For now 6.3.1 is still working fine.

@eliperelman
Copy link

@rjharmon I have shipped Neutrino v8.2.2 to pin this version of fast-async mentioned by @jzaefferer.

@trusktr
Copy link

trusktr commented Apr 9, 2018

I came to open the same error, but then I saw this issue.

I depend on fast-async ^6.3.0, and the new 6.3.2 is breaking my project with

    Cannot find module '@babel/helper-module-imports'

I'll just change from depending on ^6.3.0 to locking it to 6.3.1 for now.

trusktr added a commit to lume/cli that referenced this issue Apr 9, 2018
@matAtWork
Copy link
Collaborator

Apologies - I managed to mess up separating babel-7 beta dependancies from v6.

v6.3.4 published with no v7-beta dependencies.
v7.01.1 published for use with babel-7-beta.

Please re-open if this update does not fix the issue in your configuration.

edmorley added a commit to neutrinojs/neutrino that referenced this issue Apr 16, 2018
The `fast-async` version was pinned in 2edc81a to work around:
MatAtBread/fast-async#53

That issue was fixed in fast-async v6.3.4, so it's safe to revert
back to a tilde range again.

This only needs applying to the v8 branch, since the version was not
pinned on master (and #790 is about to remove fast-async there).
edmorley added a commit to neutrinojs/neutrino that referenced this issue Apr 16, 2018
Since:
* The default Neutrino-supported browsers (last two versions of Chrome,
  Firefox, Edge, Opera, Safari & iOS) all support async natively:
  https://caniuse.com/#feat=async-functions
* The same applies to Node 8+ (and Neutrino 9 is dropping support
  for Node 6): http://node.green/#ES2017-features-async-functions
* Neutrino 9 final will be released with Babel 7, which will likely
  include built-in support for the fast-async plugin anyway:
  babel/babel#7076
* It's another dependency to cause possible regressions, eg:
  MatAtBread/fast-async#53

Fixes #741.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants