Focus on the feature when activating feature link #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-lu-uw
force-pushed
the
feature_link_focus
branch
from
2752c04
to
4420a2d
Compare
|
Thanks @ben-lu-uw. It seems I misunderstood how feature links work: #580 (comment), for some reason I thought they'd be rerendered and refocused which would cause the feature to be announced again once visited. Instead nothing is announced when a "same-map" link is visited. Maybe @prushforth has some thoughts on this? Either way, this does improve the experience using a keyboard, maybe we can discuss the screen reader experience separately? |
Malvoz
approved these changes
Nov 30, 2021
Filed #615. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #580