Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Requests error handling (Fixes #71) #72

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

ivyleavedtoadflax
Copy link
Contributor

@ivyleavedtoadflax ivyleavedtoadflax commented Jul 22, 2023

Description

Checklist

  • Tests added
  • Relevant issue mentioned
  • Documentation updated

* Creates a hugie.exceptions module
* Creates handle_requests_error function to handle requests
  exceptions.
* Moves TokenNotSetError to exceptions module
@ivyleavedtoadflax ivyleavedtoadflax changed the title Simplify Requests error handling Simplify Requests error handling (Fixes 71) Jul 22, 2023
@ivyleavedtoadflax ivyleavedtoadflax changed the title Simplify Requests error handling (Fixes 71) Simplify Requests error handling (Fixes #71) Jul 22, 2023
@nsorros
Copy link
Contributor

nsorros commented Jul 24, 2023

In descriptions that resolve an issue, it is good to give a quick summary of the issue

@ivyleavedtoadflax
Copy link
Contributor Author

In descriptions that resolve an issue, it is good to give a quick summary of the issue

Added to description.

@ivyleavedtoadflax ivyleavedtoadflax mentioned this pull request Jul 25, 2023
3 tasks
@ivyleavedtoadflax ivyleavedtoadflax added the bug Something isn't working label Jul 25, 2023
@ivyleavedtoadflax ivyleavedtoadflax merged commit 6d177da into main Jul 27, 2023
1 check passed
@ivyleavedtoadflax ivyleavedtoadflax deleted the feature/abstract-error-handling branch July 27, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling in create command would never fire
2 participants