-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Requests error handling (Fixes #71) #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Creates a hugie.exceptions module * Creates handle_requests_error function to handle requests exceptions. * Moves TokenNotSetError to exceptions module
ivyleavedtoadflax
changed the title
Simplify Requests error handling
Simplify Requests error handling (Fixes 71)
Jul 22, 2023
ivyleavedtoadflax
changed the title
Simplify Requests error handling (Fixes 71)
Simplify Requests error handling (Fixes #71)
Jul 22, 2023
In descriptions that resolve an issue, it is good to give a quick summary of the issue |
Added to description. |
nsorros
reviewed
Jul 25, 2023
nsorros
reviewed
Jul 25, 2023
nsorros
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create
command would never fire #71 which meant that all the error handling logic for different HTTP errors across all commands (not justcreate
as described in Handle 401 and 5xx errors in endpoint list #64 and resolved in enhancement: Handle 401 and 5xx errors in endpoint list #65) would never get triggered.exceptions
module and abstracts the error handling logic for Requests errors into a handler function.test_exceptions
module to test functionality of the error handler.Checklist