Add hugie ui command (Fixes #30)
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivyleavedtoadflax
changed the title
hugie ui commandhugie ui command (Resolves #30)
ivyleavedtoadflax
changed the title
hugie ui command (Resolves #30)hugie ui command (Fixes #30)
nsorros
approved these changes
Jul 24, 2023
hard to test because it requires opening a browser, not sure it is worth mocking |
you want to mock that |
nsorros
reviewed
Jul 25, 2023
tests/test_main.py
Outdated
|
|
||
|
|
||
| def test_ui_command(monkeypatch): | ||
| def mock_open(url): |
There was a problem hiding this comment.
better to define the mock_open as a Mock https://docs.python.org/3/library/unittest.mock.html#the-mock-class and then test it is called assert_called https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called
nsorros
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #'30 by adding the
hugie uicommand which opens the Hugging Face Inference Endpoints dashboard in a browser.This may be the killer function for this tool 😬
Checklist